[PATCH] PowerPC: Add Program Priority Register support

Kalle Olavi Niemitalo kon@iki.fi
Wed Aug 15 21:47:00 GMT 2012


Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:

> +  ret4 = !(medlow_ppr_before == medlow_ppr_after);
> +
> +  return ret1 && ret2 && ret3 && ret4;

Shouldn't that be ret1 || ret2 || ret3 || ret4?
So that do_test returns 0=success only if all subtests succeeded. 
(Could also rename the variables to make it clearer which value
means success.)



More information about the Libc-alpha mailing list