[PATCH] PowerPC: Add Program Priority Register support

[Adhemerval Zanella]

Thanks again, Ryan.

On 08/14/2012 03:03 PM, Ryan S. Arnold wrote:

> With my explanation in mind, I think this comment isn't quite correct.
>  It should read as something like the following:
>
> /* The value in the Priority Program Register (PPR) is saved and restored
>    by moving its value to, and fetching its value from, a field preceding the
>    TCB that is reserved by the TLS ABI for "other thread library information".
>    Since it is the loader's responsibility to setup the TCB (and the fields in
>    the reserved space), the PPR save/restore facility is only available outside
>    of the loader.  */
>
> You could add a comment that the loader always, therefore, runs in the
> default thread priority.
> ...
>
>> diff --git a/sysdeps/powerpc/powerpc64/sysdep.h b/sysdeps/powerpc/powerpc64/sysdep.h
>> index ed96478..79566be 100644
>> --- a/sysdeps/powerpc/powerpc64/sysdep.h
>> +++ b/sysdeps/powerpc/powerpc64/sysdep.h
>> @@ -205,9 +205,26 @@ LT_LABELSUFFIX(name,_name_end): ; \
>>    TRACEBACK_MASK(name,mask)    \
>>    END_2(name)
>>
>> +/* The Priority Program Register (PPR) is saved and restored by moving its
>> +   value to ppr field in TBC. Since it is the loader responsible to setup the
>> +   TBC, the code is only built if not within the loader.  */
> Same comment applies as for ppc32.
>
> Ryan S. Arnold
>
Fair enough, comments changed to your suggestion.


-- 
Adhemerval Zanella Netto
  Software Engineer
  Linux Technology Center Brazil
  Toolchain / GLIBC on Power Architecture
  azanella@linux.vnet.ibm.com / azanella@br.ibm.com
  +55 61 8642-9890