PATCH x86_64 only: optimize sinf and cosf with SSE2

[Andreas Jaeger]

On 08/13/2012 04:06 PM, Dmitrieva Liubov wrote:
> I've fixed the sinf and cosf x86_64 patch according to requests below
> and reattach it.
>
> And yes, I intend to provide SSE optimized sincos in couple weeks for
> the patch: http://sourceware.org/ml/libc-alpha/2012-06/msg00692.html

thanks.

> Change log is the same:
>
> 2012-08-13  Liubov Dmitrieva  <liubov.dmitrieva@gmail.com>
>
>         * sysdeps/x86_64/fpu/s_sinf.S New file.
>         * sysdeps/x86_64/fpu/s_cosf.S New file.
>         * sysdeps/x86_64/fpu/libm-test-ulps Update.

you miss the colon, it's "* file: New file." etc.

> [...]
> diff --git a/sysdeps/x86_64/fpu/s_cosf.S b/sysdeps/x86_64/fpu/s_cosf.S
> new file mode 100755
> index 0000000..e9fa5a6
> --- /dev/null
> +++ b/sysdeps/x86_64/fpu/s_cosf.S
> @@ -0,0 +1,523 @@
> +/* Optimized cosf function.
> +   Copyright (C) 2012 Free Software Foundation, Inc.
> +   Contributed by Intel Corporation.

Please remove the Contributed line, we're not adding this anymore.

Thanks a lot for the detailed comments! I do have a question to the
other glibc reviewers on the style of the comments - is that one
really ok or should we enforce the usual one?

Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126