[PATCH] BZ#887 logb[l](1) shows negative sign on zero in FE_DOWNWARD rounding mode

Ryan S. Arnold ryan.arnold@gmail.com
Fri Apr 27 16:28:00 GMT 2012


On Fri, Apr 27, 2012 at 2:05 AM, Andreas Jaeger <aj@suse.com> wrote:
>> +  if (!fesetround (FE_DOWNWARD))
>> +    {
>> +
>> +      /* IEEE 754-2008 says (section 5.3.3) that "logB(1) is +0.".  Libm
>> +       * should not return -0 from logb in any rounding mode.  PowerPC32
>> has
>> +       * failed with this test for power4 logb (and logbl on all PowerPC
>> +       * platforms) in the past due to instruction selection.  GCC PR
>> 52775
>> +       * provides the availability of the fcfid insn in 32-bit mode which
>> +       * eliminates the use of fsub in this instance and prevents the
>> negative
>> +       * signed 0.0.  */
>
>
> Please remove the leading '*' and reformat.
>
>
>> +      /* BZ #887 .*/
>
>
> Two spaces after the "."
>
> Ok with those changes.

I've made the requested changes and pushed upstream with the following commit:

commit a462cb63326595eb018e26ea415f8ddc1ed50730

Ryan S. Arnold



More information about the Libc-alpha mailing list