[PATCH] Remove all traces of reg_char.

Carlos O'Donell carlos@systemhalted.org
Thu Apr 19 03:33:00 GMT 2012


On Wed, Apr 18, 2012 at 7:23 PM, David Miller <davem@davemloft.net> wrote:
> From: Roland McGrath <roland@hack.frob.com>
> Date: Wed, 18 Apr 2012 15:13:26 -0700 (PDT)
>
>> The original intent seems to have been what {,u}int_fast8_t is for.
>> So why not use that?
>
> I would say because, like reg_char, they seem utterly useless.
>
> Nobody overrides them just like nobody overrides reg_char.

The perfect is the enemy of the good. Your patch is a step forward. If
we think using {u}int_fast8_t is a win then we can do that work, but
with an eye towards the entire codebase and with experimental evidence
that it yields measurable performance improvements. As it stands
today, I agree that some types in the standard are a bit weird... like
abstract art crafted behind the closed doors of a high end studio.

Cheers,
Carlos.



More information about the Libc-alpha mailing list