Clearify running testsuite as part of patch submission

Andreas Jaeger aj@suse.com
Tue Apr 17 18:43:00 GMT 2012


On 04/17/2012 06:42 PM, Roland McGrath wrote:
> The reason for the xcheck (xtests) distinction is that these are tests that
> cannot always be run, especially in build systems and the like.
>
> Some require network connectivity.  Others might require some special setup
> on the local system or some privilege or something like that.  There are
> only a handful of them.  I haven't seen any with clear comments explaining
> what their requirements are.  Someone should go through and figure out each
> case and document its details.  It may be appropriate for developers to run
> xcheck as well as check, but we need to get clear on the individual tests'
> requirements before we can be sure.
>
> It would be wrong to have 'make check' run these tests.  If a test can be
> run safely in all circumstances, it belongs in tests rather than xtests.


Seeing that many here are not aware of "make xcheck", we can keep the 
status quo and advertize "make xcheck" - or we change something. What 
about switching them? So, check includes all tests but xcheck only those 
safe in general?

Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126



More information about the Libc-alpha mailing list