[PATCH 4/4 v2] [SH/SH4]: Fix return value which ROUND is no valid rounding mode

[Nobuhiro Iwamatsu]

2012/4/10 Carlos O'Donell <carlos@systemhalted.org>:
> On Wed, Apr 4, 2012 at 9:37 PM, Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
>>        2012-04-04  Nobuhiro Iwamatsu  <iwamatsu@nigauri.org>
>>
>>        * sysdeps/sh/sh4/fpu/fesetround.c (fesetround): Fix return value
>>        which ROUND is no valid rounding mode.
>
> The ChangeLog style should be as terse as possible:
>
> : Return 1 for invalid rounding modes, otherwise 0.
>
> ... with the git commit message being verbose.
>
>> ---
>>  sysdeps/sh/sh4/fpu/fesetround.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/sysdeps/sh/sh4/fpu/fesetround.c b/sysdeps/sh/sh4/fpu/fesetround.c
>> index 5df96d2..3269199 100644
>> --- a/sysdeps/sh/sh4/fpu/fesetround.c
>> +++ b/sysdeps/sh/sh4/fpu/fesetround.c
>> @@ -1,5 +1,5 @@
>>  /* Set current rounding direction.
>> -   Copyright (C) 1998, 2000, 2005 Free Software Foundation, Inc.
>> +   Copyright (C) 1998, 2000, 2005, 2012 Free Software Foundation, Inc.
>
> Merge years into "1998-2012"
>
>>    This file is part of the GNU C Library.
>>    Contributed by Andreas Jaeger <aj@arthur.rhein-neckar.de>, 1998.
>>
>> @@ -27,7 +27,7 @@ fesetround (int round)
>>
>>   if ((round & ~0x3) != 0)
>>     /* ROUND is no valid rounding mode.  */
>> -    return 0;
>> +    return 1;
>>
>>   /* Get current state.  */
>>   _FPU_GETCW (cw);
>> @@ -38,6 +38,6 @@ fesetround (int round)
>>   /* Set new state.  */
>>   _FPU_SETCW (cw);
>>
>> -  return 1;
>> +  return 0;
>>  }
>>  libm_hidden_def (fesetround)
>> --
>> 1.7.9.5
>>
>
> Kaz or Thomas should review these.

This already commit by f402708f8a593280992bdaf037f57c6a16c233cc.
If you can , please fix copyright year.

Best regards,
  Nobuhiro


-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6