PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap

Carlos O'Donell carlos@systemhalted.org
Sat Apr 7 01:59:00 GMT 2012


On Fri, Apr 6, 2012 at 6:00 PM, Roland McGrath <roland@hack.frob.com> wrote:
> The changes are logically separate.  "Giant" is not (just) about the number
> of lines in a patch.  It's about the conflation of multiple issues that a
> reviewer then has to tease apart again to understand the change.

I agree. Having to think about multiple issues while reviewing a patch
makes the review more difficult. The term "giant" is perhaps not the
best name for this kind of problem ;-)

Cheers,
Carlos.



More information about the Libc-alpha mailing list