[PATCH] memset: fix define usage for shared libs

David Miller davem@davemloft.net
Thu Apr 5 01:47:00 GMT 2012


From: Mike Frysinger <vapier@gentoo.org>
Date: Wed, 4 Apr 2012 21:42:28 -0400

> On Wednesday 04 April 2012 21:32:11 David Miller wrote:
>> From: Mike Frysinger <vapier@gentoo.org>
>> > The proper define to check "am I in a shared lib" is "SHARED", not "PIC".
>> > The two new memset_chk functions incorrectly depend on "PIC".
>> 
>> I'm ambivalent on this one, because there are other locations
>> where we essentially test libc.a vs. libc.so using PIC too.
> 
> where ?  i'll fix them.  we (Gentoo) notice fairly quickly because our hardened 
> systems build everything as PIC/PIE.  ChromeOS too.

sysdeps/unix/sysv/linux/i386/sysdep.S, for example.

Perhaps that situation is different, but at least the comment even
talks about shared vs. non-shared.



More information about the Libc-alpha mailing list