[PATCH v2 9/10] Tilera (and Linux asm-generic) support for glibc

Roland McGrath roland@hack.frob.com
Fri Nov 11 18:11:00 GMT 2011


> 2011-11-09  Chris Metcalf  <cmetcalf@tilera.com>
> 
>   * bits/byteswap.h (__bswap*): Use __builtin_bswap for gcc 4.3 and
>   above.  Improves code generation for gcc 4.3 and 4.4 compilers
>   without bswap pattern detection.

ChangeLog indentation is wrong.  Don't use * or other such
abbreviations--list all the macros you touched by name.

This seems reasonable if some GCC folks can confirm that 4.3 and later
produce optimal code for __builtin_bswap{32,64} on all machines.


Thanks,
Roland



More information about the Libc-alpha mailing list