[PATCH 1/2] Add support fedisableexcept, feenableexcept, fegetexcept and feupdateenv for Renesas sh4

Nobuhiro Iwamatsu iwamatsu@nigauri.org
Thu May 26 13:43:00 GMT 2011


Hi,

Thanks for your review.

2011/5/24 Kaz Kojima <kkojima@rr.iij4u.or.jp>:
> Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
>> 2011-05-23  Nobuhiro Iwamatsu  <iwamatsu@nigauri.org>
>>
>>       * sysdeps/sh/sh4/fpu/fedisblxcpt.c:
>>       Add support fedisableexcept for Renesas sh4.
>>       * sysdeps/sh/sh4/fpu/feenablxcpt.c:
>>       Add support feenableexcept for Renesas sh4.
>>       * sysdeps/sh/sh4/fpu/fegetexcept.c:
>>       Add support fegetexcept for Renesas sh4.
>>       * sysdeps/sh/sh4/fpu/feupdateenv.c:
>>       Add support feupdateenv for Renesas sh4.
>
> Use the usual style like as other ChangeLog entries:
>
>        * sysdeps/sh/sh4/fpu/fedisblxcpt.c: New file.
>        * sysdeps/sh/sh4/fpu/feenablxcpt.c: New file.
>        ...
>
> and don't send the diff file for ChangeLog.
OK.

> Other part of the patch looks OK to me, though I guess
> your patches require copyright assignment.  Do you have
> FSF copyright assignment?

No, but I will do this.
I will send new patch after I did copyright assignment.

Best regards,
  Nobuhiro
>
> Regards,
>        kaz
>

-- 
Nobuhiro Iwamatsu



More information about the Libc-alpha mailing list