PATCH: Mark __dso_handle hidden

[H.J. Lu]

On Thu, Jun 16, 2011 at 4:22 AM, Ulrich Drepper <drepper@gmail.com> wrote:
> On Wed, Jun 15, 2011 at 15:44, Jakub Jelinek <jakub@redhat.com> wrote:
>> That will break linking with old gcc versions and non-gcc compilers.
>> While it is fine to require recent gcc versions to build glibc itself,
>> atexit is in libc_nonshared.a.
>
> Agreed.  There has to be a really good reason to sacrifice the support
> for these environments.  Yes, atexit won't perform 100% correct, but
> at least it works in the main executable which is all you can do with
> these platforms.
>
> HJ, why should we care whether atexit takes a handful more cycles to
> execute?  What other reasons are there?
>

On another platform, bad atexit implementation called from DSO caused
weird run-time problems. The same problem can happen with glibc.  The
worse thing can happen with my patch is people will old compilers will
get a link-time error, instead of strange run-time problems.


-- 
H.J.