[PATCH] PowerPC64 - Fix INTERNAL_[V]SYSCALL_NCS macros to not cast return val to (int)
Roland McGrath
roland@redhat.com
Tue Feb 15 21:27:00 GMT 2011
There are some extraneous parens in several places, but that doesn't matter
much. The test fails to check for malloc failure. If it does fail, writev
will either fail with EFAULT or crash anyway, so that is no critical. The
return value from main on failure should be just 1 or 2 or something, not
what might be an arbitrary large number.
Otherwise the test looks good to me now.
I don't know if the actual fix in the powerpc code might have some other
ramifications and someone else would have to say about that. Since the
other syscall macros return a long int value, I assume it's probably fine.
Thanks,
Roland
More information about the Libc-alpha
mailing list