[PATCH] memcpy-ssse3: enable chk symbols in static builds

[Mike Frysinger]

On Sunday, February 06, 2011 18:06:51 H.J. Lu wrote:
> On Sun, Feb 6, 2011 at 2:54 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Sunday, February 06, 2011 17:46:45 H.J. Lu wrote:
> >> On Sun, Feb 6, 2011 at 10:28 AM, Mike Frysinger <vapier@gentoo.org> 
wrote:
> >> > 2011-02-06  Mike Frysinger  <vapier@gentoo.org>
> >> > 
> >> >        * sysdeps/x86_64/multiarch/memcpy-ssse3.S: Delete SHARED ifdef
> >> > check around MEMCPY_CHK symbol.
> >> >        * sysdeps/x86_64/multiarch/memcpy-ssse3-back.S: Likewise.
> >> 
> >> I don't think it is correct.  Please try this.
> > 
> > i dont think either are correct now that you posted this.  the whole file
> > is protected by:
> > #if !defined NOT_IN_libc \
> >    && (defined SHARED \
> >        || defined USE_AS_MEMMOVE \
> >        || !defined USE_MULTIARCH)
> > 
> > so there isnt much point in checking any of these inside of that.  just
> > delete the whole #if protection from the MEMCPY_CHK symbol.
> 
> We don't want to define memcpy_chk in libc.a twice,

how is that relevant ?  if the code does:
#if !defined(A) && defined(B)

then in the middle does:
#if defined(B)

the 2nd check is pointless.  that's all your updated patch does.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20110207/6bafc293/attachment.sig>