[PATCH] memset: fix define usage for shared libs

Mike Frysinger vapier@gentoo.org
Mon Apr 18 03:51:00 GMT 2011


On Sunday, April 17, 2011 21:12:00 Ulrich Drepper wrote:
> On Tue, Feb 22, 2011 at 13:28, Mike Frysinger <vapier@gentoo.org> wrote:
> > The proper define to check "am I in a shared lib" is "SHARED", not "PIC".
> > The two new memset_chk functions incorrectly depend on "PIC".
> 
> What is failing without this patch?

building the static libs as PIC

> I should just discard any patch which comes without justification.

i already gave you justification -- PIC is not the right symbol to check for 
code going shared libraries.  that is entirely why SHARED was added.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20110418/f80da6e8/attachment.sig>


More information about the Libc-alpha mailing list