[PATCH] Fix POWER4/POWER7 optimized strncmp to not read past differing bytes

Ryan Arnold ryan.arnold@gmail.com
Mon Apr 18 01:04:00 GMT 2011


It corrects the behavior exposed in the bug.

I think you should apply it and we'll submit a patch later after we do
some performance analysis if we find any significant performance
regression.  I have someone looking at it right now.

What kind of runway do we have for making 2.14?  If nothing else we
can get the 2.14 maintainer to backport a perf fix after the branch is
tagged.

Ryan

On Sun, Apr 17, 2011 at 7:51 PM, Ulrich Drepper <drepper@gmail.com> wrote:
> On Mon, Mar 28, 2011 at 14:47, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> 2011-03-28  Andreas Schwab  <schwab@linux-m68k.org>
>>
>>        * sysdeps/powerpc/powerpc32/power4/strncmp.S: Don't read past
>>        differing bytes.
>>        * sysdeps/powerpc/powerpc64/power4/strncmp.S: Likewise.
>>        * sysdeps/powerpc/powerpc32/power7/strncmp.S: Likewise.
>>        * sysdeps/powerpc/powerpc64/power7/strncmp.S: Likewise.
>
> Is this patch correct?  I haven't seen anything from the ppc people.
>



More information about the Libc-alpha mailing list