[PATCH 1/4] Don't take the address of a void object.

Carlos O'Donell carlos@systemhalted.org
Fri Mar 26 21:07:00 GMT 2010


On Fri, Mar 26, 2010 at 12:16 PM, Richard Henderson <rth@twiddle.net> wrote:
> GCC 4.5 warns about "extern void _end; &end;".
> Use char[] instead, as that also doesn't fall foul
> of a target's .sdata optimizations.

Thanks for all the GCC 4.5 fixes!

> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  ChangeLog                           |    7 +++++++
>  csu/gmon-start.c                    |    4 ++--
>  elf/dl-sysdep.c                     |    6 +++---
>  sysdeps/unix/sysv/linux/dl-sysdep.c |    8 ++++----
>  4 files changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 8117882..72cbef6 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,10 @@
> +2010-03-26  Richard Henderson  <rth@redhat.com>
> +
> +       * csu/gmon-start.c (ENTRY_POINT, etext): Declare as char[], not void.
> +       * elf/dl-sysdep.c (_end): Likewise.
> +       * sysdeps/unix/sysv/dl-sysdep.c (frob_brk): Likewise with locally
> +       declared _end, and associated variables.
> +

Normal libc-alpha policy says not to include the ChangeLog in the diff.
http://sourceware.org/glibc/wiki/Contribution%20checklist#GNU_ChangeLog

I did not see any approval from Roland or Ulrich for these patches.

Do you have blanket commit privileges?

If you do, may I update the MAINTAINERS portion of the wiki?
http://sourceware.org/glibc/wiki/MAINTAINERS

If you have blanket commit privileges, would you be willing to review patches?

Cheers,
Carlos.



More information about the Libc-alpha mailing list