[PATCH] powerpc: Cleanup old obsolete PPC_REL16 checks
Luis Machado
luisgpm@linux.vnet.ibm.com
Thu Feb 11 15:03:00 GMT 2010
On Tue, 2010-02-09 at 10:32 -0800, Ulrich Drepper wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 02/08/2010 10:23 AM, Luis Machado wrote:
> > Ok?
>
> Not quite. You completely removed the configure test. Instead it
> should be rewritten to fail in case the binutils is too old.
Should the test be binutils-version-oriented (we already fail based on
Binutil's version number IIRC)? Or should I just fail if PPC_REL16 is
not supported with a message like "gas doest not support PPC_REL16.
Binutil is too old."?
I'm inclined to take the second approach.
> Also, as even the shortest look at the ChangeLog file would have shown
> you we always use "Likewise" and not "Ditto".
Ok. I'll fix that.
> - --
> â§ Ulrich Drepper â§ Red Hat, Inc. â§ 444 Castro St â§ Mountain View, CA â
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAktxqlMACgkQ2ijCOnn/RHS/5ACgwJAn+UWSBJ7AdgrDI+cQrscf
> FjoAnRQ2YwvWNbp2F2bO1Pca/SIXODo4
> =nIWb
> -----END PGP SIGNATURE-----
More information about the Libc-alpha
mailing list