cruft patrol

Lu, Hongjiu hongjiu.lu@intel.com
Thu Aug 26 20:47:00 GMT 2010


Hi Roland,

Did you run "make check" on Intel Core i7? I got

make[4]: *** [/export/build/gnu/glibc-sse/build-x86_64-linux/string/noinl-tester.out] Error 1
make[4]: *** [/export/build/gnu/glibc-sse/build-x86_64-linux/string/test-strcspn.out] Error 1
make[4]: *** [/export/build/gnu/glibc-sse/build-x86_64-linux/string/test-strpbrk.out] Error 1
make[4]: *** [/export/build/gnu/glibc-sse/build-x86_64-linux/string/test-strspn.out] Error 1
make[3]: *** [string/xtests] Error 2
make[4]: *** [/export/build/gnu/glibc-sse/build-x86_64-linux/posix/tst-rxspencer.out] Error 1
make[3]: *** [posix/xtests] Error 2
make[2]: *** [xcheck] Error 2
make[1]: *** [check] Error 2
make: *** [cont] Error 2

H.J.


> -----Original Message-----
> From: Roland McGrath [mailto:roland@redhat.com]
> Sent: Wednesday, August 25, 2010 12:16 PM
> To: Lu, Hongjiu
> Cc: GNU libc hacker
> Subject: cruft patrol
> 
> I just committed some fixes to eliminate compiler warnings in some of
> the
> new string code.  There was also some poor indentation, sloppy typing,
> and
> a data definition gratuitously in assembly that I changed to C.
> Please try
> to get this stuff cleaner before committing in the future.
> 
> 
> Thanks,
> Roland



More information about the Libc-alpha mailing list