Too large messages on glibc-cvs@
Jim Meyering
jim@meyering.net
Wed Nov 4 16:53:00 GMT 2009
Petr Baudis wrote:
> On Tue, Jun 09, 2009 at 11:09:56PM +0200, Jim Meyering wrote:
>> Roland McGrath wrote:
>> > Jim is our local expert on the git scripts.
>> > But I'm sure this issue is not new among all other projects using git.
>> > If anybody else has script hacks for this stuff, please come forward.
>>
>> I noticed those, too. I wrote/posted a tiny script to insert into the
>> existing hook. I'll actually test and install it Thursday or Friday.
>
> I'm now adding this hook to repo.or.cz and I'd like to do this too,
> I'm wondering, how did you do this?
Hi Petr,
I wrote this limit-pipe script:
http://sourceware.org/ml/libc-ports/2009-05/msg00056.html
but I never got around to making the hook use it.
I can do something like this to the post-receive-email script
we're currently using (with a probable PATH update):
- generate_email $oldrev $newrev $refname | send_mail
+ generate_email $oldrev $newrev $refname |
+ limit-pipe 524288 | send_mail
On second thought, that limit, 512KB (just made up by me, btw),
has to come from config, set via e.g.,
git config hooks.email-max-size 524288
since it's per-repo policy, while the hook script is typically shared.
On the other hand, since no one has complained about overly-large
messages in 4 months, maybe it's not worth doing after all.
If no one says they want it (and provides a max message size),
I'll presume there's no need. Same applies to libc-ports.
Jim
More information about the Libc-alpha
mailing list