[PATCH] Don't use undefined macros

Andrew Stubbs ams@codesourcery.com
Mon Feb 2 17:02:00 GMT 2009


Jakub Jelinek wrote:
> On Thu, Jan 29, 2009 at 03:14:17PM +0000, Andrew Stubbs wrote:
>> It's possible to have neither FUTEX_CLOCK_REALTIME nor 
>> __ASSUME_FUTEX_CLOCK_REALTIME defined. In this case nptl/init.c fails to 
>> compile.
> 
> How is it possible?  Every nptl target is supposed to define it in
> lowlevellock.h.  If you are using some targets for which lowlevellock.h
> hasn't been updated, you should update it rather than doing workarounds in a
> wrong place.

OK, well it isn't defined in 
nptl/sysdeps/unix/sysv/linux/sh/lowlevellock.h or in 
nptl/sysdeps/unix/sysv/linux/sh/sh4/lowlevellock.h

This was not a problem until this patch was applied:
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/nptl/init.c.diff?r1=1.74&r2=1.75&cvsroot=glibc&f=h

I notice a similar fix in a recent patch from Joseph here:
http://sourceware.org/ml/libc-ports/2009-01/msg00007.html

So here's a patch to do the same on SH.

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: glibc-FUTEX_CLOCK_REALTIME.patch
Type: text/x-diff
Size: 737 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20090202/28866f20/attachment.bin>


More information about the Libc-alpha mailing list