SH, S390: (not) calling __gmon_start__ from pt-initfini.c
Andreas Krebbel
krebbel@linux.vnet.ibm.com
Wed Dec 9 15:39:00 GMT 2009
Hi Thomas,
the S/390 part looks ok to me but I think the ".L22" label should go away as well.
I've run the libc testsuite on s390 and s390x with your patch without seeing
regressions.
However I cannot approve your patch. Let's wait for comments from Martin.
Bye,
-Andreas-
> 2009-11-27 Thomas Schwinge <thomas@codesourcery.com>
>
> * sysdeps/unix/sysv/linux/s390/s390-32/pt-initfini.c (_init): Don't
> call __gmon_start__.
> * sysdeps/unix/sysv/linux/s390/s390-64/pt-initfini.c (_init): Likewise.
>
>
> Index: nptl/sysdeps/unix/sysv/linux/s390/s390-32/pt-initfini.c
> ===================================================================
> --- nptl/sysdeps/unix/sysv/linux/s390/s390-32/pt-initfini.c (revision 9312)
> +++ nptl/sysdeps/unix/sysv/linux/s390/s390-32/pt-initfini.c (working copy)
> @@ -1,5 +1,5 @@
> /* Special .init and .fini section support for S/390.
> - Copyright (C) 2003 Free Software Foundation, Inc.
> + Copyright (C) 2003, 2009 Free Software Foundation, Inc.
> This file is part of the GNU C Library.
>
> The GNU C Library is free software; you can redistribute it
> @@ -67,8 +67,6 @@
> .LT1_0:\n\
> .LC13:\n\
> .long __pthread_initialize_minimal_internal-.LT1_0\n\
> -.LC14:\n\
> - .long __gmon_start__@GOT\n\
> .LC15:\n\
> .long _GLOBAL_OFFSET_TABLE_-.LT1_0\n\
> .LTN1_0:\n\
> @@ -80,11 +78,6 @@
> L 1,.LC13-.LT1_0(13)\n\
> LA 1,0(1,13)\n\
> BASR 14,1\n\
> - L 1,.LC14-.LT1_0(13)\n\
> - L 1,0(1,12)\n\
> - LTR 1,1\n\
> - JE .L22\n\
> - BASR 14,1\n\
> .L22:\n\
> #APP\n\
> .align 4,0x07\n\
> Index: nptl/sysdeps/unix/sysv/linux/s390/s390-64/pt-initfini.c
> ===================================================================
> --- nptl/sysdeps/unix/sysv/linux/s390/s390-64/pt-initfini.c (revision 9312)
> +++ nptl/sysdeps/unix/sysv/linux/s390/s390-64/pt-initfini.c (working copy)
> @@ -1,5 +1,5 @@
> /* Special .init and .fini section support for 64 bit S/390.
> - Copyright (C) 2003 Free Software Foundation, Inc.
> + Copyright (C) 2003, 2009 Free Software Foundation, Inc.
> This file is part of the GNU C Library.
>
> The GNU C Library is free software; you can redistribute it
> @@ -68,11 +68,6 @@
> STG 1,0(15)\n\
> LARL 12,_GLOBAL_OFFSET_TABLE_\n\
> BRASL 14,__pthread_initialize_minimal_internal\n\
> - LARL 1,__gmon_start__@GOTENT\n\
> - LG 1,0(1)\n\
> - LTGR 1,1\n\
> - JE .L22\n\
> - BASR 14,1\n\
> .L22:\n\
> #APP\n\
> .align 4,0x07\n\
>
>
> Regards,
> Thomas
More information about the Libc-alpha
mailing list