[patch soft-fp] Fixes for soft-fp

Fredrik Unger fred@tree.se
Mon Dec 1 15:39:00 GMT 2008


Hi,


My name is Fredrik Unger, and I am a member of a team porting
the GCC to the NEC SX vector computer series.
( http://en.wikipedia.org/wiki/SX_architecture )

http://code.google.com/p/sx-gcc/

In an initial mail to gcc-patches
http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01354.html
I reported some soft-fp problem.

The fixdfti-floatuntisf.patch was accepted into gcc
and informed me that double.h.patch belongs to libc.

===== double.h problem =====

When compiling soft-fp for a platform with _FP_W_TYPE_SIZE = 64,
the macro definitions for FP_UNPACK_SEMIRAW_D and FP_UNPACK_SEMIRAW_DP
are not correct.

_FP_UNPACK_RAW_1 should be called as the _FP_W_TYPE_SIZE is
equal 64 and the first argument can not be a 1.
The first argument declares an union type :
union _FP_UNION_##fs  (in op-1.h)
and _FP_UNION_1 is not a valid union while _FP_UNION_D is
declared in double.h.

-------- Test regressions/bugtracker information ---------

With this patch fixed our problem for the SX platform with
gcc.dg/torture/fp-int-convert-timode.c
and is partially logged at
http://code.google.com/p/sx-gcc/issues/detail?id=46

=============================

Regarding FSF copyright Assignment I have not signed any
copyright assignment. However the patch so small that I assume
it will be treated as a tiny change.

So here is the patch for double.h, with a ChangeLog entry.

(ChangeLog suggestion, I am a new submitter)

2008-12-01  Fredrik Unger  <fred@tree.se> (tiny change)

	* libc/soft-fp/double.h: Corrected define macro.
	Fixed FP_UNPACK_SEMIRAW_* for _FP_W_TYPE_SIZE >= 64.


If there are any specific comments with regards to soft-fp we
would be interested in hearing them. We have chosen soft-fp over
fp-bit in our GCC port, but if something speaks against it we
are interested in hearing about it.

Please let me know if you need more information.

Thanks,

Fredrik Unger

-------------- next part --------------
A non-text attachment was scrubbed...
Name: double.h.patch
Type: text/x-patch
Size: 634 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20081201/cdf81c58/attachment.bin>


More information about the Libc-alpha mailing list