[PATCH] S/390: Fix 31/64 bit utmp compat problem

Ulrich Drepper drepper@redhat.com
Thu Apr 24 15:41:00 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andreas Krebbel wrote:
> I've tested the patch on s390 and s390x using the libc testsuite.  A
> small 64bit utmp testcase linked against an older libc version runs
> fine with the new version using the compat functions.

Yes, it shows you put a lot of quality testing into the patch.  Have you
even reviewed it?  All the garbage you sent?

Plus: you don't modify generic code.  The only change allowed is perhaps
something like

+#ifndef updwtmp
 weak_alias (__updwtmp, updwtmp)
+endif

Everything else must be handle in arch-specific files.


> Ok to apply?

What do you mean by that?  You wouldn't apply the patch anyway.

- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQFIEJmy2ijCOnn/RHQRAgb1AJ9u2ZBxtWtTHWH4YHkuaL0lhOcR4gCfTZqq
CpZKlHJneS/w1a1Q/4xP6UE=
=PKDv
-----END PGP SIGNATURE-----



More information about the Libc-alpha mailing list