[PATCH] getaddrinfo() dest. addr. selection Rule 7 bugfix

Ulrich Drepper drepper@redhat.com
Wed Mar 7 07:48:00 GMT 2007


Sridhar Samudrala wrote:
> I thought of doing this. Currently __check_pf() is called once for each
> getaddrinfo() call before we get the list of destination addresses.
> The new RTM_GETROUTE call needs to be done after we get the destination
> address list and once for each dest. address.

And?  Why should this be a problem with reusing the socket?  It's a lame
excuse for not wanting to do the work.


> Are you suggesting using the same socket for RTM_GETROUTE and
> SIOCGHWADDR calls.

No, I did not.  I suggest, though, to use the same socket for all
necessary SIOCGHWADDR calls.


> Can we do a SIOCGHWADDR ioctl on a netlink socket?

I don't know.  I didn't suggest using the ioctl.


> I am not fully familiar with the glibc coding standards, but i tried to
> follow the syntax of the existing code as much as possible.

Then you did an extremely poor job.  Most lines you didn't copy from
somewhere are wrong.


> I think it will be much easier for you to make these changes to fix this
> issue and treat this as a bug report with a suggested solution.

Then say from the beginning that you're not interested in fixing the
problem and have me waste time by explaining them.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20070307/ee93b858/attachment.sig>


More information about the Libc-alpha mailing list