[PATCH] PPC32 factored context functions part 2

Steven Munroe munroesj@us.ibm.com
Wed Dec 14 02:09:00 GMT 2005


Ulrich Drepper wrote:

> Steven Munroe wrote:
>
>>     * sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/getcontext.S:
>>     New file.
>
> Why create a fpu subdir?  The default is with fpu, the nofpu subdir 
> takes care of the rest.
>
corrected.

>> +#else
>> +#include "getcontext-common.S"
>> +#endif
>
> Indentation...
>
indented.

>> +#if SHLIB_COMPAT (libc, GLIBC_2_3_3, GLIBC_2_3_4)
>> +    compat_text_section
>> +   
>> +#undef __CONTEXT_FUNC_NAME   
>> +#define __CONTEXT_FUNC_NAME __novec_getcontext
>> +#undef __CONTEXT_ENABLE_VRS
>
> Indentation...
> and many, many more cases
>
and indented across cases and all files.

>> +    mr    4,3
>> +    li    3,0
>> +    li    5,_UC_SIZE_2_3_4;
>
> Use consistently rN instead of just N.
>
corrected.

>> +#define _UC_SIZE    1184
>
> Why is this defined?  It is not  used.
>
removed.

>> +#define _UC_SIZE_2_3_4    1184
>
> There is no appropriate extension to the TESTS macro.  Do you think we 
> add these tests for fun?
>
This is the size of the ucontext which is required as the 3rd parameter 
to the __NR_swapcontext syscall. The TEST macro does not support sizeof().


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ppc32-context-20051212.txt
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20051214/6eb224a1/attachment.txt>


More information about the Libc-alpha mailing list