[regex] BZ #522 Enable UTF-8 and ASCII optimizations outside glibc, take 2
Ulrich Drepper
drepper@redhat.com
Mon Nov 8 22:22:00 GMT 2004
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
This patch is not correct.
First, you introduce additional work in the glibc path. There is no
need to check for UTF8, we know it is UTF-8.
Second, the dfa->mb_cur_max == 6 test does not necessarily apply to all
platforms. It should be removed outside of glibc.
In fact, the glibc code should stay as is.
You also introduced an inconsistency: the regex_internal code uses
isascii() while you explicitly test for <= 127.
I made these changes and applied the patch.
- --
â§ Ulrich Drepper â§ Red Hat, Inc. â§ 444 Castro St â§ Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFBj/Fk2ijCOnn/RHQRArBOAKCcA8g83e/Q02CLjSHBR1Hh/zKQAgCgyagU
G7L4/QvCerGa1vsZGCTwAiY=
=51CC
-----END PGP SIGNATURE-----
More information about the Libc-alpha
mailing list