[regex] Remove dead code

Ulrich Drepper drepper@redhat.com
Mon Nov 8 16:07:00 GMT 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paolo Bonzini wrote:
> This patch removes several unused parameters and struct fields.

The patch does not apply correctly.  Once I fix it by hand it does not
compile.  When I leave out

@@ -602,7 +600,7 @@ re_search_internal (preg, string, length
   re_dfa_t *dfa = (re_dfa_t *)preg->buffer;
   int left_lim, right_lim, incr;
   int fl_longest_match, match_first, match_kind, match_last = -1;
- -  int fast_translate, sb, ch;
+  int sb, ch;
 #if defined _LIBC || (defined __STDC_VERSION__ && __STDC_VERSION__ >=
199901L)
   re_match_context_t mctx = { .dfa = dfa };
 #else

it compiles and seems to work.  So, beside this hunk the changes look
OK.  I applied the patch.  The ChangeLog was not correct either.  No
directory name, and the second file changed was regexec.c.  Please pay
more attention.

- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBj5mQ2ijCOnn/RHQRAq5NAJ9hq142o1EsisZADPPrPS/qV8EerQCfR9bk
meddClJBl83yu8BqXKsFCEs=
=aBrP
-----END PGP SIGNATURE-----



More information about the Libc-alpha mailing list