mktime.c fixes (part 2 of 6): don't reject pre-1969 timestamps

Ulrich Drepper drepper@redhat.com
Thu Jan 1 22:34:00 GMT 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> Sorry, I don't follow what you're saying.  Surely you're not arguing
> that glibc must not offer any extensions to POSIX?

Extensions are certainly not welcome.  These interfaces are ill-designed
and should not be used for anything but the bare minimum.


> (If that were
> true, glibc would have to require that 'long int' must be only 32 bits
> wide, since anything wider is a POSIX extension.  :-)

What?  There is no requirement in the size of time_t.


>   (2) whether times are normalized before or after any overflow checking.

Then implement this with the absolutely minimal patch.  I have
confidence in the existing code and none whatsoever in this giant patch
of yours.  If anything is changed the code must reject every input which
results in negative time_t value.

- -- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/9J/U2ijCOnn/RHQRAkawAKCj1pUIM/DVOCekmQercEgxUgMJ6wCfUgF0
RLo3aRKevUmWgYpRGi/HYP8=
=L/qH
-----END PGP SIGNATURE-----



More information about the Libc-alpha mailing list