[PATCH] po2test.sed is not valid sed

Paolo Bonzini paolo.bonzini@polimi.it
Mon Mar 24 10:55:00 GMT 2003


po2test.sed uses two times the same label.  This AFAICT is undefined behavior 
according to POSIX, and besides it works only by chance (because the two 
bodies of code for msgid and msgstr are the same).

I also intend to find out whether it is fine to make this a hard error and do 
that in future GNU sed releases, so it's time to fix these.

This patch fixes the problem by putting the loop out of { }.

While looking at it, I also found that the second substitution in the loop is 
never done.

-- 
|_  _  _ __
|_)(_)| ) ;'_.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: po2test-fix-bad-labels.sed
Type: text/x-diff
Size: 2470 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20030324/bfe0d9b2/attachment.bin>


More information about the Libc-alpha mailing list