p{read,write}{,64} mips n64 changes

Andreas Jaeger aj@suse.de
Thu Mar 20 19:25:00 GMT 2003


Alexandre Oliva <aoliva@redhat.com> writes:

> On Mar 20, 2003, Andreas Jaeger <aj@suse.de> wrote:
>
>>      __LONG_LONG_PAIR ((type) ((var) >> 32), \
>> 		      (type) ((var) & 0xffffffff))
>
>> Is this not feasible?
>
> The `>> 32' and truncation with `& 0xffffffff' is only used in the
> off64_t versions (pread64 and pwrite64), but not in the off_t versions
> (pread and pwrite).  In fact, shifting by 32 would invoke undefined
> behavior in the off_t versions, so we'd have to make it two shifts
> instead.

I see.  So, let's go with the original patch and whatever clever idea
you have ;-)

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj



More information about the Libc-alpha mailing list