p{read,write}{,64} mips n64 changes

Andreas Jaeger aj@suse.de
Sat Mar 15 06:19:00 GMT 2003


Alexandre Oliva <aoliva@redhat.com> writes:

> @@ -59,8 +65,13 @@ __libc_pread (fd, buf, count, offset)
>      {
>       /* First try the syscall.  */
>       assert (sizeof (offset) == 4);
> +#if defined _ABI64 && _MIPS_SIM == _ABI64
> +     result = INLINE_SYSCALL (pread, 6, fd, CHECK_N (buf, count), count, 0,
> +			      offset);
> +#else
>       result = INLINE_SYSCALL (pread, 6, fd, CHECK_N (buf, count), count, 0,
>  			      __LONG_LONG_PAIR (offset >> 31, offset));

Can't we use a macro here that does the right thing?

E.g. __LONG_LONG_ARGUMENT (offset) which extends on n64 to just offset
and on other ABIs to __LONG_LONG_PAIR ?

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj



More information about the Libc-alpha mailing list