[PATCH]: MIPS clone.S compile fix
Daniel Jacobowitz
drow@mvista.com
Thu Mar 13 14:56:00 GMT 2003
On Thu, Mar 13, 2003 at 03:49:37PM +0100, Guido Guenther wrote:
> Hi,
> newer binutils forbid branches to globally visible symbols on mips (see
> <ork7g48ygm.fsf@free.redhat.lsd.ic.unicamp.br>. The attached patch makes
> clone.S compilable again - no new test failures.
> Regards,
> -- Guido
Even newer binutils allow them again. But I think this patch is a good
idea anyway.
Content-Description: clone-local-label.diff
> 2003-03-13 Guido Guenther <agx@sigxcpu.org>
>
> * sysdeps/unix/sysv/linux/mips/clone.S: introduce and use local label
> .Lthread_start since current binutils don't allow branches to globally
> visible symbols.
>
> ===================================================================
> RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/mips/clone.S,v
> retrieving revision 1.10
> diff -u -r1.10 clone.S
> --- sysdeps/unix/sysv/linux/mips/clone.S 12 Mar 2003 01:04:51 -0000 1.10
> +++ sysdeps/unix/sysv/linux/mips/clone.S 12 Mar 2003 19:04:39 -0000
> @@ -63,7 +63,7 @@
> syscall
>
> bnez a3,error
> - beqz v0,__thread_start
> + beqz v0,.Lthread_start
>
> /* Successful return from the parent */
> addiu sp,32
> @@ -85,6 +85,7 @@
> debug info. */
>
> ENTRY(__thread_start)
> +.Lthread_start:
> /* cp is already loaded. */
> .cprestore 16
> /* The stackframe has been created on entry of clone(). */
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
More information about the Libc-alpha
mailing list