bits/mathinline.h change from 2. June breaks i586

Thorsten Kukuk kukuk@suse.de
Wed Jun 4 13:06:00 GMT 2003


Hi,

the following patch:

2003-06-02  Bernd Schmidt  <bernds@redhat.com>

        * sysdeps/i386/fpu/bits/mathinline.h (sqrt, __sqrtl, ldexp,
        ldexpf, ldexpl): Only define if __FAST_MATH__.

breaks compiling of glibc on i586. I get the following error:

/usr/src/packages/BUILD/glibc-2.3/cc/stdlib/drand48_r.o.dt
In file included from ../math/math.h:362,
                 from ../include/math.h:3,
                 from drand48_r.c:21:   
../sysdeps/i386/fpu/bits/mathinline.h: In function `ldexpf':  
../sysdeps/i386/fpu/bits/mathinline.h:590: error: `__ldexp_code' undeclared (first use in this function)
../sysdeps/i386/fpu/bits/mathinline.h:590: error: (Each undeclared identifier is reported only once
../sysdeps/i386/fpu/bits/mathinline.h:590: error: for each function it appears in.)
../sysdeps/i386/fpu/bits/mathinline.h:591: warning: no return statement in function returning non-void

I don't think the patch is correct or complete, since ldexpf is not
wrapped by __FAST_MATH__.

Since I couldn't find the reason for this change, I don't know if the
appended patch is correct. At least it fixed my problem and glibc
compiles again.

  Thorsten
-- 
Thorsten Kukuk       http://www.suse.de/~kukuk/        kukuk@suse.de
SuSE Linux AG        Deutschherrnstr. 15-19        D-90429 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B
-------------- next part --------------
--- sysdeps/i386/fpu/bits/mathinline.h
+++ sysdeps/i386/fpu/bits/mathinline.h	2003/06/04 12:49:26
@@ -582,7 +582,6 @@
 #ifdef __USE_ISOC99
 #ifdef __FAST_MATH__
 __inline_mathop_declNP (log2, "fld1; fxch; fyl2x", "0" (__x) : "st(1)")
-#endif /* __FAST_MATH__ */
 
 __MATH_INLINE float
 ldexpf (float __x, int __y) __THROW
@@ -596,7 +595,6 @@
   __ldexp_code;
 }
 
-#ifdef __FAST_MATH__
 __inline_mathcodeNP3 (fma, __x, __y, __z, return (__x * __y) + __z)
 
 __inline_mathopNP (rint, "frndint")


More information about the Libc-alpha mailing list