[PATCH] PPC32 cancellation support

[Franz Sirl]

On Saturday 04 January 2003 21:33, Jakub Jelinek wrote:
> On Sat, Jan 04, 2003 at 05:06:01PM +0100, Franz Sirl wrote:
> >	* linuxthreads/sysdeps/unix/sysv/linux/powerpc/powerpc32/sysdep-cancel.h:
> >	New file.
>
> Thanks for working on this.

I'm forced to, if I want to keep my system uptodate :-). Any idea about the 
AIO problem?

> > 	* sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list: Mark
> > 	__syscall_pread64 and __syscall_pwrite64 cancellable.
>
> IMHO the cancellation wrappers belong to linux/powerpc/{pread,pwrite}.c,
> not to the __syscall_ stubs (ie. include sysdep-cancel.h instead of
> sysdep.h in the C code and use LIBC_CANCEL_ASYNC and LIBC_CANCEL_RESET
> macros together with SINGLE_THREAD_P.

Hmm, what advantage would that have? The PSEUDO macro is there now and the 
generated code of the compiler is not as good.

> Also, why doesn't it use INLINE_SYSCALL?

To avoid 64-bit argument aligning problems, was discussed before with Roland. 
In general don't like the INLINE_SYSCALL/INTERNAL_SYSCALL very much. They 
don't have the type checking the __syscall_* stuff enforced and it's hard to 
expose the features of the PPC syscall interface via it cause they only 
return a single (int) as a statement expression.

Franz.