make existing mips files multi-ABI

Alexandre Oliva aoliva@redhat.com
Sat Apr 5 16:40:00 GMT 2003


On Apr  5, 2003, Andreas Jaeger <aj@suse.de> wrote:

> Alexandre Oliva <aoliva@redhat.com> writes:
>> +/* As tempting as it is to define this, the userland data structures
>> +   are not identical, because of different padding.  Perhaps they
>> +   should be?  */
>> +/* # define XSTAT_IS_XSTAT64 1 */

> Please remove that comment and the last sentence of the define.

You mean, remove all of what you quoted above, along with the
enclosing #if/#endif (that would then be empty)?  I thought it would
be good to document why we can't use xstat for xstat64, since I myself
must have thought of it a number of times, and actually tried it at
least twice before believing it couldn't be used :-)

> We don't need extension here, this file is internal to glibc.

Thanks, I wasn't sure.

Fixed below.  I've also cvs added the truncate64 files mentioned in
the ChangeLog but that hadn't made it to my earlier cvs diff, so I'll
ask for approval again.  No other files were modified.  Ok?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mips64-n32-n64-stat.patch
Type: text/x-patch
Size: 8153 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20030405/db209f06/attachment.bin>
-------------- next part --------------

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer


More information about the Libc-alpha mailing list