pread, pwrite linux implementation does not conform to Single Unix Specification

[Andreas Schwab]

Ulrich Drepper <drepper@redhat.com> writes:

|> On Wed, 2002-07-17 at 11:52, Andreas Schwab wrote:
|> 
|> > -			   __LONG_LONG_PAIR (0, offset));
|> > +			   __LONG_LONG_PAIR (-(offset < 0), offset));
|> 
|> Why do you use
|> 
|>   -(offset < 0)

Because that is obvious.

|> instead of
|> 
|>   offset >> (sizeof (offset) * 8 - 1)

Because right shifting of negative numbers is implementation-defined, and
I didn't know that older gcc optimize it better.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."