ftw() and AustinDraft

Ulrich Drepper drepper@redhat.com
Fri Dec 14 16:19:00 GMT 2001


Thorsten Kukuk <kukuk@suse.de> writes:

> -  if (__access (dir, R_OK) != 0)
> +  if (__access (dir, X_OK) != 0)
>      return -1;
> +  else
> +    {
> +      char *bdir = dirname (strdupa (dir));
> +       if (__access (bdir, R_OK) != 0)
> +          return -1;
> +    }

I doubt this is correct.  Why should the status of the directory
containing another directory have any effect?  Also, what if the
parameter is not for a directory but a file?  This isn't disallowed.

Before looking at any more patches I want to see some extensions to
the testsuite.  We'll see whether we agree on the expected result and
then look for a patch.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------



More information about the Libc-alpha mailing list