one more tweak for the ISO-2022-CN-EXT converter

Ulrich Drepper drepper@redhat.com
Sun Sep 24 15:47:00 GMT 2000


Bruno Haible <haible@ilog.fr> writes:

> The ISO-2022-CN-EXT converter uses bits 2..17 for its internal state,
> but bits 0..2 are sometimes cleared by the consume_incomplete feature
> (iconv/loop.c:388 and iconv/skeleton.c:591). Currently this feature is
> only enabled by mbrtowc, therefore no bug is visible, but it's still
> dangerous because
>   - it's a bad example for other converters,
>   - the consume_incomplete feature might be used in other situations in
>     the future.

I agree.  This is what I intended.  I had a bug in there and you fixed
it the one way (meaning, with a shift count of 2).  Thanks for the
correction, it's now in.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------


More information about the Libc-alpha mailing list