LinuxThreads cancellation bug.

[Ulrich Drepper]

Kaz Kylheku <kaz@ashi.footprints.net> writes:

> If cancelation is disabled the pthread_cancel function bails without
> recording that a cancelation request was made. This is incorrect
> behavior, because the application cannot temporarily disable
> cancelation around code without potentially losing a cancelation
> request.

I agree with this.

> I believe that the fix is simply to remove the test.

This surely isn't true.  Instead we probably should move

  th->p_canceled = 1;

before the test.  The next cancelstate change will then have the
desired effect.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------