[Bug default/31513] abidiff wrongly considers data members moved to base class as harmful

dodji at seketeli dot org sourceware-bugzilla@sourceware.org
Fri Mar 29 17:40:33 GMT 2024


https://sourceware.org/bugzilla/show_bug.cgi?id=31513

--- Comment #11 from Dodji Seketeli <dodji at seketeli dot org> ---
Hello,

I have posted a candidate patch for this issue in commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=338394f5454990c715b52bb4bc2ed47b39d6528b.
 You can get it from the Git repository of the project in the branch
"users/dodji/fixes" that can be browsed at
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/fixes.

You can check it out with the command: git clone -b users/dodji/fixes
git://sourceware.org/git/libabigail.git.  You can build the source code by
following the instructions at
https://sourceware.org/git/?p=libabigail.git;a=blob;f=COMPILING.

Please note that running abidiff on the two binaries that you provided shows
that several functions (instantiations of libstdc++ function templates) were
removed from the first binary.  That is why abidiff sets the bit
ABIDIFF_ABI_INCOMPATIBLE_CHANGE in the exit value.

To suppress the noise coming from these libstdc++ function template
instantiations (which could be avoided by using the symbol visibility options
of g++, by the way), I provided a suppression file in the non-regression tests
accompanying the patch at
https://sourceware.org/git/?p=libabigail.git;a=blob;f=tests/data/test-abidiff-exit/PR31513/reported/libstdcpp.suppr;h=6c3761006a7c304c8a98dfd2a74097ef9e3282e2;hb=338394f5454990c715b52bb4bc2ed47b39d6528b.

You might want to test this branch on your system and tell me if that fixes the
issue for you.  I hope this helps.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Libabigail mailing list