[Bug default/31513] abidiff differences due to change in compiler version

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31513

--- Comment #10 from dodji at redhat dot com ---
"quic_ashudas at quicinc dot com" <sourceware-bugzilla@sourceware.org>
writes:

> https://sourceware.org/bugzilla/show_bug.cgi?id=31513
>
> --- Comment #8 from Ashutosh Das (QUIC) <quic_ashudas at quicinc dot com> ---
> Thanks for sharing the detailed analysis.

You are welcome.

> I understand that this some developers might be interested in knowing more
> about such changes, however as we agree this are compatible changes in that
> case the abidiff return code should not return value 12 (suggests incompatible
> change).

Oh, I didn't realize that the return code was:

    (ABIDIFF_ABI_CHANGE | ABIDIFF_ABI_INCOMPATIBLE_CHANGE).

It should indeed be ABIDIFF_ABI_CHANGE.

Now I think that is the real bug.

> Can we make this error messages as warning and return a compatible return code.

Sure.  The return code should indeed be ABIDIFF_ABI_CHANGE (suggesting a
review from the user).

That is the real bug.

Thinking more about that, I am even thinking that we might go further
and filter that change out by default.

Thanks again for reporting this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.