[PATCH] DWARF reader: use size_t for DWARF expression length cont.

Dodji Seketeli dodji@seketeli.org
Tue Jan 18 15:58:59 GMT 2022


Giuliano Procida <gprocida@google.com> a écrit:

> From: Mark Wielaard <mark@klomp.org>
>
> A recent change broke 32-bit builds due to an implicit assumption that
> size_t == uint64_t. Note that size_t is part of the elfutils
> dwarf_getlocation* functions' types.
>
> The previous fix omitted some instances of uint64_t. This commit
> updates further functions to consistently use size_t for DWARF
> expression lengths and indexes.
>
> 	* src/abg-dwarf-reader.cc (eval_last_constant_dwarf_sub_expr):
> 	Change expr_len argument type to size_t.
> 	(op_pushes_constant_value): Update ops_len and index argument
> 	types to size_t. Update next_index argument type to size_t&.
> 	(op_pushes_non_constant_value): Likewise.
> 	(op_is_arith_logic): Update expr_len and index argument types
> 	to size_t. Update next_index argument type to size_t&.
> 	(op_is_control_flow): Likewise.
>
> Fixes: 16207c4af7bc ("Bug 28191 - Interpret DWARF 5 addrx locations")
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Applied to master, thanks!

[...]

Cheers,

-- 
		Dodji


More information about the Libabigail mailing list