[PATCH] DWARF reader: use size_t for more DWARF expression length

Mark Wielaard mark@klomp.org
Tue Jan 18 13:14:16 GMT 2022


Hi,

On Tue, 2022-01-18 at 14:03 +0100, Mark J. Wielaard wrote:
> From: Mark Wielaard <mark@klomp.org>
> 
> commit 6e0d3f7 "DWARF reader: use size_t for DWARF expression
> length" is a partial fix for the assumption that size_t == uint64_t.
> 
> This commit updates a couple more functions where this (wrong)
> assumption was made.
> 
> 	* src/abg-dwarf-reader.cc (eval_last_constant_dwarf_sub_expr):
> 	Change expr_len argument type to size_t*.
> 	(op_pushes_constant_value): Change ops_len and index argument
> 	types to size_t; change next_index argument type to size_t&.
> 	(op_pushes_non_constant_value): Likewise.
> 	(op_is_arith_logic): Change expr_len and index argument
> 	types to size_t; change next_index argument type to size_t&.
> 	(op_is_control_flow): Likewise.
> 
> Fixes: 16207c4af7bc ("Bug 28191 - Interpret DWARF 5 addrx locations")
> Signed-off-by: Mark Wielaard <mark@klomp.org>

Sorry, this is equivalent to Giuliano's patch in 
https://sourceware.org/pipermail/libabigail/2022q1/004114.html
I was confused about was was/wasn't committed.

Cheers,

Mark


More information about the Libabigail mailing list