[PATCH] DWARF reader: use size_t for DWARF expression length

Dodji Seketeli dodji@seketeli.org
Tue Jan 18 12:03:47 GMT 2022


Giuliano Procida <gprocida@google.com> a écrit:

> A recent change broke 32-bit builds due to an implicit assumption that
> size_t == uint64_t. This appears in the elfutils dwarf_getlocation*
> functions' types.
>
> This commit updates callers and other functions to use size_t
> consistently for such expression lengths and indexes.
>
> 	* src/abg-dwarf-reader.cc (die_location_expr): Change expr_len
> 	argument type to size_t*.
> 	(op_manipulates_stack): Change expr_len and index argument
> 	types to size_t; change next_index argument type to size_t&.
> 	(eval_last_constant_dwarf_sub_expr): Change expr_len argument
> 	and local variables index and next_index types to size_t.
> 	(die_member_offset): Change local variable expr_len type to
> 	size_t.
> 	(die_location_address): Likewise.
> 	(die_virtual_function_index): Likewise.
>
> Fixes: 16207c4af7bc ("Bug 28191 - Interpret DWARF 5 addrx locations")
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Applied to master, thanks!

[...]

Cheers,

-- 
		Dodji


More information about the Libabigail mailing list