[PATCH] ctf-reader: Assert on ir::hash_as_canonical_type_or_constant
Guillermo Martinez
guillermo.e.martinez@oracle.com
Tue Dec 21 17:28:11 GMT 2021
On Tuesday, December 21, 2021 10:22:33 AM CST Dodji Seketeli wrote:
> Hello Guillermo,
>
> "Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
> écrit:
>
> [...]
>
> Thanks for the patch!
>
> I have tested this patch and I've found some issues. Please find my
> comments below:
>
> > diff --git a/tests/test-read-ctf.cc b/tests/test-read-ctf.cc
> > index b448ddc5..7f5381f6 100644
> > --- a/tests/test-read-ctf.cc
> > +++ b/tests/test-read-ctf.cc
> > @@ -220,6 +220,54 @@ static InOutSpec in_out_specs[] =
> > "data/test-read-ctf/PR27700/test-PR27700.abi",
> > "output/test-read-ctf/PR27700/test-PR27700.abi",
> > },
> > + {
> > + "data/test-read-ctf/test-callback.o",
>
> This *.o is not present in the patch. I think the remaining *.o
> below are not present in the patch either. So test/runtestreadctf
> fails.
>
> Also, you need to add these files to the tests/data/Makefile.am file.
>
> As I've said elsewhere in the past, "make distcheck-fast" can help you
> check if the files are really present in the tarball.
Ohh, apologises, I'll do that. Dodji thanks for your comments!
> [...]
>
> Cheers,
More information about the Libabigail
mailing list