[PATCH 2/5] XML writer: use exemplar types for tracking referenced types

[Dodji Seketeli]

Matthias Maennich <maennich@google.com> a écrit:

> The emitted type sets are used with some referenced type sets (which use
> bare type pointers). To keep consistency between what is being recorded
> in each set, switch to storing exemplar type pointers in the referenced
> type sets.
>
> This change results in the omission of a small number of duplicate
> types from various test cases. In each case the duplicates were
> previously caused by a referenced type being emitted for one
> translation unit and then the same type being emitted as a canonical
> type for a later translation unit.
>
> It also causes the movement of some function types in some test cases.
> Some of those types are now considered referenced and appear earlier as
> a result.
>
> 	* src/abg-writer.cc (record_type_as_referenced): Use preferred
> 	type with referenced type sets.
> 	(type_is_referenced): Likewise.
> 	(tests/data/test-annotate/test14-pr18893.so.abi): Duplicate
> 	type(s) removed, as described above.
> 	(tests/data/test-read-dwarf/test14-pr18893.so.abi): Likewise.
> 	(tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi):
> 	Likewise.
> 	(tests/data/test-read-dwarf/test16-pr18904.so.abi): Likewise.
> 	(tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi):
> 	Likewise.
> 	(tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi):
> 	Likewise.
> 	(tests/data/test-read-dwarf/PR25007-sdhci.ko.abi): Some
> 	function type(s) reordered, as described above.
> 	(tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi):
> 	Likewise.
> 	(tests/data/test-annotate/test15-pr18892.so.abi):: Duplicate
> 	type(s) removed and some function type(s) reordered, as
> 	described above.
> 	(tests/data/test-read-dwarf/test15-pr18892.so.abi): Likewise.
> 	(tests/data/test-annotate/test21-pr19092.so.abi): Likewise.
> 	(tests/data/test-read-dwarf/test21-pr19092.so.abi): Likewise
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>

Applied to master, thanks!

[...]

Cheers,

-- 
		Dodji