[PATCH v3] Bug 28191 - Interpret DWARF 5 addrx locations

[Mark Wielaard]

Hi,

On Tue, Nov 23, 2021 at 06:15:27PM +0100, Dodji Seketeli wrote:
> It seems to me that we can also do away with the use of eval_last_constant_dwarf_sub_expr from
> die_member_offset.  Would that work on your testing binaries?
> 
> From what I am seeing, dwarf_getlocation_attr and dwarf_getlocation are
> present in elfutils 0.176 which is the oldest version that we need to
> support, so we should be able to ditch eval_last_constant_dwarf_sub_expr
> and its dependencies altogether.

I don't know the libabigail code too well, but
eval_last_constant_dwarf_sub_expr seem to be a partial Dwarf
Expression evaluator. elfutils libdw doesn't export one (it really
should though). So I think you still need that code when you get a
non-trivial location expression.

Cheers,

Mark