[PATCH 1/3] ctf-reader: Use argument by reference reading the context
Guillermo Martinez
guillermo.e.martinez@oracle.com
Thu Nov 18 23:09:38 GMT 2021
On Thursday, November 18, 2021 11:26:41 AM CST Dodji Seketeli wrote:
> Hello Guillermo,
Hello Dodji
> Thanks for your patch!
>
> I just have some small nits to pick.
>
> Please find my comments below:
Thanks!
> "Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
> écrit:
>
> > * src/abg-ctf-reader.cc (read_context): Use const argument
> > pass by reference.
> > (create_read_context): Likewise.
>
> Here each line should be prefixed by a "tab", as explained in the
> COMMIT-LOG-GUIDELINES file in the source tree at
> https://sourceware.org/git/?p=libabigail.git;a=blob_plain;f=COMMIT-LOG-GUIDELINES;hb=HEAD.
>
> Also, there are some changes in the the file include/abg-ctf-reader.h.
> I added them to this ChangeLog part of the commit log.
Thanks!
> You'll find my updated version of your patch below. Would you please
> sign it off by adding a line starting by "Signed-off-by:" with your name
> and email, as explained in the file CONTRIBUTING at
> https://sourceware.org/git/?p=libabigail.git;a=blob_plain;f=CONTRIBUTING;hb=HEAD
> ? I need that sign-off before committing the patch.
Ok, I will do.
> Thanks a lot!
Thanks to you for the comments!
> From ee0308d607b36fc4c5e3e4d815deb7ecf8884ad6 Mon Sep 17 00:00:00 2001
> From: "Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org>
> Date: Wed, 17 Nov 2021 20:56:04 -0600
> Subject: [PATCH] ctf-reader: Use argument by reference reading the context
>
> * include/abg-ctf-reader.h (create_read_context): Pass the string
> by reference.
> * src/abg-ctf-reader.cc (ctf_reader::read_context): Likewise.
> (create_read_context): Likewise.
>
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>
> ---
> include/abg-ctf-reader.h | 8 ++++----
> src/abg-ctf-reader.cc | 5 +++--
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/include/abg-ctf-reader.h b/include/abg-ctf-reader.h
> index c0d8bb2b..56b2bf91 100644
> --- a/include/abg-ctf-reader.h
> +++ b/include/abg-ctf-reader.h
> @@ -25,10 +25,10 @@ namespace ctf_reader
> {
>
> class read_context;
> -read_context *create_read_context (std::string elf_path,
> - ir::environment *env);
> -corpus_sptr read_corpus (read_context *ctxt,
> - elf_reader::status& status);
> +read_context *create_read_context(const std::string& elf_path,
> + ir::environment *env);
> +corpus_sptr read_corpus(read_context *ctxt,
> + elf_reader::status& status);
>
> } // end namespace ctf_reader
> } // end namespace abigail
> diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc
> index 0370c8aa..2c2c204d 100644
> --- a/src/abg-ctf-reader.cc
> +++ b/src/abg-ctf-reader.cc
> @@ -102,7 +102,7 @@ public:
> /// Constructor.
> ///
> /// @param elf_path the path to the ELF file.
> - read_context(string elf_path, ir::environment *env)
> + read_context(const string& elf_path, ir::environment *env)
> {
> types_map.clear();
> filename = elf_path;
> @@ -1060,7 +1060,8 @@ slurp_elf_info(read_context *ctxt, corpus_sptr corp)
> /// @param env a libabigail IR environment.
>
> read_context *
> -create_read_context(std::string elf_path, ir::environment *env)
> +create_read_context(const std::string& elf_path,
> + ir::environment *env)
> {
> return new read_context(elf_path, env);
> }
Cheers,
Guillermo
More information about the Libabigail
mailing list