[Bug default/26571] New: get_vmlinux_path_from_kernel_dist contains useless code

gprocida+abigail at google dot com sourceware-bugzilla@sourceware.org
Thu Sep 3 11:29:44 GMT 2020


            Bug ID: 26571
           Summary: get_vmlinux_path_from_kernel_dist contains useless
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida+abigail at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

get_vmlinux_path_from_kernel_dist has the following statement:

  if (dir_exists(dist_root + "/lib/modules"))
    dist_root + "/lib/modules";

It should probably read:

  if (dir_exists(dist_root + "/lib/modules"))
    dist_root += "/lib/modules";

However, I don't know if the existing behaviour is now relied on by anything.

There is also a confusing (copy/paste?) comment referring to "/usr/lib/debug".

(This bug report was brought to you with the assistance of clang-tidy which
flagged that "dist_root" was an unnecessary copy of "from".)

You are receiving this mail because:
You are on the CC list for the bug.

More information about the Libabigail mailing list